Merged
Conversation
Contributor
ilyabrin
commented
Sep 19, 2025
ilyabrin
commented
- Analyzed current testing approach and issues - Identified that VCR was overkill since we were creating mock data anyway
- Replaced VCR with Faraday test adapter - Migrated from VCR to Faraday's built-in test adapter
- Created test helper for HTTP mocking - Built comprehensive HTTP mocking infrastructure in spec/support/http_stubs.rb
- Fixed all existing tests to use new approach - Converted all test files from VCR to Faraday test adapter
- Implemented tests for all new services - Created and fixed tests for all 6 new API services
- Removed VCR dependencies and files - Completely removed VCR from the project
- Run final test suite to ensure all tests pass
Pull Request Test Coverage Report for Build 17872802188Details
💛 - Coveralls |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.